On 3/29/2017 2:07 AM, Ed Czeck wrote:
> * Flesh out device configuration
> * Add links dev_ops
> * allow dynamic extension loading
>
> v6:
> * Address review issues
> * Unify messages and logging
> * Improved error capturing
>
> Signed-off-by: Shepard Siegel <shepard.sie...@atomicrules.com>
> Signed-off-by: John Miller <john.mil...@atomicrules.com>
> Signed-off-by: Ed Czeck <ed.cz...@atomicrules.com>
<...>
> + /* Setup the packet generator */
> + if (ark->pkt_gen_args) {
> + PMD_DRV_LOG(INFO, "Setting up the packet generator\n");
> + ark_pktgen_parse(ark->pkt_gen_args);
> + ark_pktgen_reset(ark->pg);
> + ark_pktgen_setup(ark->pg);
> + ark->start_pg = 1;
> + }
> +
> + /* Setup the packet checker */
> + if (ark->pkt_chkr_args) {
> + ark_pktchkr_parse(ark->pkt_chkr_args);
> + ark_pktchkr_setup(ark->pc);
> + }
This cause build error [1] with clang, which seems a valid one.
[1]
.../drivers/net/ark/ark_ethdev.c:940:11: error: address of array
'ark->pkt_gen_args' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
if (ark->pkt_gen_args) {
~~ ~~~~~^~~~~~~~~~~~
.../drivers/net/ark/ark_ethdev.c:949:11: error: address of array
'ark->pkt_chkr_args' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
if (ark->pkt_chkr_args) {
~~ ~~~~~^~~~~~~~~~~~~
