On Thu, Mar 23, 2017 at 8:13 AM, Ferruh Yigit <ferruh.yi...@intel.com> wrote: >
> > > > +static > > +int > > Can be in same line. Fixed > > > +check_for_ext(struct rte_eth_dev *dev __rte_unused, > > + struct ark_adapter *ark __rte_unused) > > __rte_unused can go away Fixed > Hi Ed, > > Can you give some more details on "user extension" that loaded dynamically? > > How much the driver depends on it, what happens if the library is missing? > > And how do you deliver that shared library? > Dynamic libraries arem optional user provided extensions to the PMD. The driver funcations correctly without one. Here is the blurb from our doc file: doc/guides/nics/ark.rst The ARK PMD user extensions are a feature of Arkville’s DPDK net/ark poll mode driver, allowing users to add their own code to extend the net/ark functionality without having to make source code changes to the driver. One motivation for this capability is that while DPDK provides a rich set of functions to interact with NIC-like capabilities (e.g. MAC addresses and statistics), the Arkville RTL IP does not include a MAC. Users can supply their own MAC or custom FPGA applications, which may require control from the PMD. The user extension is the means providing the control between the user's FPGA application and the existing DPDK features via the PMD.
