Hi Kuba, > -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kuba Kozak > Sent: Friday, March 3, 2017 12:08 AM > To: dev@dpdk.org > Cc: Piasecki, JacekX; Kozak, KubaX > Subject: [dpdk-dev] [PATCH 2/4] net/e1000: add grouping of xstats for e1000 > driver > > From: Jacek Piasecki <jacekx.piase...@intel.com> > > This patch extends the 'rte_igb_xstats_name_off' structure with additional > field > 'group_mask'. For each xstats there is now specified group (e.g. TX_GROUP), > one xstatistic can be in several groups. > To implement new functionality of retriving xstats by group on driver level, > there > are two functions added: > eth_igb_xstats_get_by_group() and eth_igb_xstats_get_names_by_group() > > Signed-off-by: Jacek Piasecki <jacekx.piase...@intel.com> > Signed-off-by: Kuba Kozak <kubax.ko...@intel.com > > #define IGBVF_NB_XSTATS (sizeof(rte_igbvf_stats_strings) / \ @@ -1771,6 > +1832,13 @@ struct rte_igb_xstats_name_off { > stats->cexterr += E1000_READ_REG(hw, E1000_CEXTERR); > stats->tsctc += E1000_READ_REG(hw, E1000_TSCTC); > stats->tsctfc += E1000_READ_REG(hw, E1000_TSCTFC); > + > + if (hw->mac.type == e1000_i350 || hw->mac.type == e1000_i210) { > + stats->o2bgptc += E1000_READ_REG(hw, E1000_O2BGPTC); > + stats->o2bspc += E1000_READ_REG(hw, E1000_O2BSPC); > + stats->b2ospc += E1000_READ_REG(hw, E1000_B2OSPC); > + stats->b2ogprc += E1000_READ_REG(hw, E1000_B2OGPRC); > + } Seems this code doesn't belong to this topic. Could it be split to an isolate patch?
BTW, I can only find 3 patches in this patch set. 4/4 is missing.
