Hi Chenghu,
> -----Original Message----- > From: Chenghu Yao [mailto:yao.chen...@zte.com.cn] > Sent: Wednesday, December 21, 2016 10:04 AM > To: Lu, Wenzhuo; Zhang, Helin > Cc: dev@dpdk.org; Chenghu Yao > Subject: [PATCH v2] net/ixgbe/base: clear redundant macro define > > In head file "ixgbe_mbx.h", macro define IXGBE_VF_API_NEGOTIATE and > IXGBE_VF_GET_QUEUES appear two times with the same name, value, and > notes. > > Version 2.0 VF requests can inherit the two macro defines in previous version > 1.0 and 1.1. Otherwise, maybe cause confusion. As 1.x is for linux/freebsd, but 2.0 is for solaris, 2.0 doesn't leverage the messages from 1.x. For example, 0x0a has different meaning in 1.x and 2.0. So better letting it be.
