Hi, On Tuesday 30 August 2016 09:17 PM, Ferruh Yigit wrote: > On 8/26/2016 2:57 PM, Shreyansh Jain wrote: >> Remove the 'name' member from rte_pci_driver and move to generic rte_driver. >> >> Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(<name>..) >> as well as assigning a name to eth_driver.pci_drv.name member. >> In this patch, only the original DRIVER_REGISTER_PCI(<name>..) name has been >> populated into the rte_driver.name member - assignments through eth_driver >> has been removed. >> >> Signed-off-by: Jan Viktorin <viktorin at rehivetech.com> >> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com> >> --- > > There are a few name fields: > > 1) eth_dev->data->name > 2) eth_dev->data->drv_name > 3) rte_driver->name > 4) dev_info->driver_name > > > What should be the relation between them? > > I guess 1) is device_name, 2, 3, 4 are same thing and driver_name.
Yes, (1) is the ethernet device name. (2), (3) are same, i.e. driver name (4) is an output field for eth_dev_info_get method and would represent same thing as (2) and (3). > > If this is correct, virtual drivers needs to be updated for this, > because for them 3 != (2 == 4). They all use global variable for 2 & 4. Ok. I didn't notice this. I will check it once again. > > And what do you think removing 2) completely? > I guess it exists for virtual devices, since for them eth_driver is not > exists and not able to access to rte_driver->name from eth_dev, but this > is solvable. Ok. Probably, one way to solve is to make eth_dev->driver point to rte_vdev_driver. That way, rte_driver->name would replace eth_dev->data->drv_name. I will give it a thought. Thanks for pointing out. > > > Thanks, > ferruh > - Shreyansh
