On Monday 29 August 2016 10:19 PM, Ferruh Yigit wrote: > On 8/26/2016 2:57 PM, Shreyansh Jain wrote: >> Remove the 'name' member from rte_pci_driver and move to generic rte_driver. >> >> Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(<name>..) >> as well as assigning a name to eth_driver.pci_drv.name member. >> In this patch, only the original DRIVER_REGISTER_PCI(<name>..) name has been >> populated into the rte_driver.name member - assignments through eth_driver >> has been removed. >> >> Signed-off-by: Jan Viktorin <viktorin at rehivetech.com> >> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com> >> --- >> app/test/test_pci.c | 10 +++++++--- >> app/test/virtual_pmd.c | 2 +- >> drivers/crypto/qat/qat_qp.c | 2 +- >> drivers/net/bnx2x/bnx2x_ethdev.c | 2 -- > > bnx2x_rxtx.c also needs to be updated: > > CC bnx2x_rxtx.o > ..../drivers/net/bnx2x/bnx2x_rxtx.c:22:25: error: no member named 'name' > in 'struct rte_pci_driver' > dev->driver->pci_drv.name, ring_name, > dev->data->port_id, queue_id); > > .... > > > Also szedata2 driver seems missed: > > CC rte_eth_szedata2.o > ..../drivers/net/szedata2/rte_eth_szedata2.c:1575:4: error: field > designator 'name' does not refer to any field in type 'struct > rte_pci_driver' > .name = RTE_SZEDATA2_PCI_DRIVER_NAME, > ^ > > >
Ok - I will fix this. It seems I really need a better way to test before sending out the patches. - Shreyansh
