On Fri, May 13, 2016 at 03:45:52PM -0700, Stephen Hurd wrote:
> Move init() cleanup into uninit() function
> Fix .dev_private_size
> Add require hwrm calls:
> bnxt_hwrm_func_driver_register()
> bnxt_hwrm_func_driver_unregister()
>
> Signed-off-by: Stephen Hurd <stephen.hurd at broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde at broadcom.com>
> ---
> drivers/net/bnxt/bnxt.h | 1 +
> drivers/net/bnxt/bnxt_ethdev.c | 48 ++++--
> drivers/net/bnxt/bnxt_hwrm.c | 50 ++++++
> drivers/net/bnxt/bnxt_hwrm.h | 3 +
> drivers/net/bnxt/hsi_struct_def_dpdk.h | 277
> ++++++++++++++++++++++++++++++++-
> 5 files changed, 359 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
> index 0f816ed..ebddeab 100644
> --- a/drivers/net/bnxt/bnxt.h
> +++ b/drivers/net/bnxt/bnxt.h
> @@ -91,6 +91,7 @@ struct bnxt {
> struct rte_pci_device *pdev;
>
> uint32_t flags;
> +#define BNXT_FLAG_REGISTERED (1<<0)
> #define BNXT_FLAG_VF (1<<1)
> #define BNXT_PF(bp) (!((bp)->flags & BNXT_FLAG_VF))
> #define BNXT_VF(bp) ((bp)->flags & BNXT_FLAG_VF)
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index a74cc6c..07519df 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -52,20 +52,12 @@ static struct rte_pci_id bnxt_pci_id_map[] = {
> {.device_id = 0},
> };
>
> -static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
> -{
> - struct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;
> -
> - rte_free(eth_dev->data->mac_addrs);
> - bnxt_free_hwrm_resources(bp);
> -}
> -
It seems strange to remove this code given that it was just added in the
previous
commit. Does it need to be added in the first place?
Regards,
/Bruce
