On Fri, May 13, 2016 at 03:45:51PM -0700, Stephen Hurd wrote:
> Start adding HWRM support.
> Initial commit just performs necessary HWRM queries for init, then
> fails as before.
>
> Thee used HWRM calls so far:
> bnxt_hwrm_func_qcaps:
> Queries device capabilities.
>
> bnxt_hwrm_ver_get:
> Gets the firmware version and interface specifications.
> Returns an error if the firmware on the device is not
> supported by the driver and ensures the response space
> is large enough for the largest possible response.
>
> bnxt_hwrm_queue_qportcfg:
> Required to get the default queue ID.
>
> Signed-off-by: Stephen Hurd <stephen.hurd at broadcom.com>
> Reviewed-by: David Christensen <david.christensen at broadcom.com>
Can you please clarify in the commit message what HWRM acronym stands for.
Checkpatch also highlights a few minor issues that might be worth addressing.
CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#137: FILE: drivers/net/bnxt/bnxt.h:94:
+#define BNXT_FLAG_VF (1<<1)
^
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#259: FILE: drivers/net/bnxt/bnxt_ethdev.c:143:
+ /*
+ eth_dev->rx_pkt_burst = &bnxt_recv_pkts;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#366: FILE: drivers/net/bnxt/bnxt_hwrm.c:56:
+ unsigned i;
Regards,
/Bruce
