Hi, On 05/12/2016 03:32 AM, John Daley (johndale) wrote: >> This patch removes the unused flags from rte_mbuf, and their use in >> the drivers. The enic driver is modified to drop bad packets, but >> i40e and fm10k are kept as they are today and should be fixed to >> drop bad packets. > > Perhaps the change to enic to drop bad packets should be handled as a > separate patch since it's not strictly related to not removing the > use of the flags?
Yes, it's probably better to have it in a separate patch. >> John, I did not test the patch on the enic driver, so please review >> it carefully. >> > > The patch works for enic, thanks. There are a few minor changes for > performance: - put an unlikely in the if (packet_error) conditional - > remove the if (!packet_error) conditional since it will always be > true. Let me know if you would prefer I submit the enic patch > separately. I'll do it, thanks for reviewing. I'll wait a bit for other comments before sending a first version of the patchset. Regards, Olivier
