Hi, > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Friday, April 29, 2016 5:25 AM > To: dev at dpdk.org; Zhang, Helin <helin.zhang at intel.com> > Cc: Ananyev, Konstantin <konstantin.ananyev at intel.com>; John Daley > (johndale) <johndale at cisco.com> > Subject: removing mbuf error flags > > Hi, > > In rte_mbuf.h, some rx flags are set to 0 since a long time since nearly 2 > years. It means nobody use them. They were introduced by the following > commit: > > http://dpdk.org/browse/dpdk/commit/?id=c22265f6 > > As far as I understand, these flags were introduced to let the application > know that a received packet is invalid. > > The 2 drivers using them are i40e and enic. But as this flags are 0 today, it > means that invalid packets are silently given to the application. > > My opinion is that invalid packets should not be given to the application and > only a statistic counter should be incremented. > No application check these flags today (in examples, or testpmd). > > I would like to remove these flags. > Thoughs?
I agree. Enic needs a little work to increment a counter and update internal indexes correctly. If you are in a hurry, feel free to 's/PKT_RX_MAC_ERR/0/' in enic for now. -John
