On Mon, Mar 21, 2016 at 06:24:36PM +0900, Tetsuya Mukawa wrote: > 2016-03-21 17:37 GMT+09:00 Thomas Monjalon <thomas.monjalon at 6wind.com>: > > 2016-03-21 14:45, Tetsuya Mukawa: > >> This event will be occured when some queues are enabled or disabled. > >> So far, only vhost PMD supports the event, and it indicates some queues > >> are enabled or disabled by virtio-net device. Such an event is needed > >> because virtio-net device may not enable all queues vhost PMD prepare. > >> > >> Because only vhost PMD uses the event so far, it isn't an actual hardware > >> interrupt but a simple software event. > > [...] > >> > >> + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, > >> + /**< queue state changed interrupt */ > > > > Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough? > > > > What about this comment? > > /**< queue state event (enabled/disabled) */ > > Hi Thomas, > > Yes, it's enough, and above comment is nice. > Thanks for suggestion. > > > Hi Bruce, > > If today is the deadline, could you kindly please replace above > changes while merging? > I need half a day to re-submit the patch. Sorry for asking it. > I will ask my company to let me have vpn access. ;) > > Regards, > Tetsuya
Yes, I can fix on apply to dpdk-next-net. /Bruce