2016/03/18 ??9:27 "Bruce Richardson" <bruce.richardson at intel.com>:
>
> On Tue, Mar 15, 2016 at 05:31:41PM +0900, Tetsuya Mukawa wrote:
> > The patch introduces a new PMD. This PMD is implemented as thin wrapper
> > of librte_vhost. It means librte_vhost is also needed to compile the
PMD.
> > The vhost messages will be handled only when a port is started. So start
> > a port first, then invoke QEMU.
> >
> > The PMD has 2 parameters.
> > - iface: The parameter is used to specify a path to connect to a
> > virtio-net device.
> > - queues: The parameter is used to specify the number of the queues
> > virtio-net device has.
> > (Default: 1)
> >
> > Here is an example.
> > $ ./testpmd -c f -n 4 --vdev 'eth_vhost0,iface=/tmp/sock0,queues=1' --
-i
> >
> > To connect above testpmd, here is qemu command example.
> >
> > $ qemu-system-x86_64 \
> > <snip>
> > -chardev socket,id=chr0,path=/tmp/sock0 \
> > -netdev vhost-user,id=net0,chardev=chr0,vhostforce,queues=1 \
> > -device virtio-net-pci,netdev=net0,mq=on
> >
> > Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp>
> > Acked-by: Ferruh Yigit <ferruh.yigit at intel.com>
> > Acked-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> > Acked-by: Rich Lane <rich.lane at bigswitch.com>
> > Tested-by: Rich Lane <rich.lane at bigswitch.com>
>
> Hi Tetsuya,
>
> I hope to get this set merged for RC2 very soon. Can you provide an
update for
> the nic overview.rst doc listing out the features of this new PMD. If you
want,
> you can provide it as a separate patch, that I will merge into this one
for you
> on apply to next-net.
>
> If you do decide to respin this patchset with the extra doc, please take
into
> account the following patchwork issues also - otherwise I'll also fix
them on
> apply:
>
> WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should
probably be static const char * const
> #364: FILE: drivers/net/vhost/rte_eth_vhost.c:56:
> +static const char *valid_arguments[] = {
>
> WARNING:LINE_SPACING: Missing a blank line after declarations
> #399: FILE: drivers/net/vhost/rte_eth_vhost.c:91:
> + char *iface_name;
> + volatile uint16_t once;
>
> WARNING:TYPO_SPELLING: 'Unknow' may be misspelled - perhaps 'Unknown'?
> #684: FILE: drivers/net/vhost/rte_eth_vhost.c:376:
> + RTE_LOG(ERR, PMD, "Unknow numa node\n");
>
> Regards,
> /Bruce
>
Hi Bruce,
I've sent the v12 patch with vhost.rst.
Could you please check below?
http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=64
Is this the documentation I need to add?
Anyway, it contains above nits. So could you please fix it before merging,
if it's the documentation?
Regards,
Tetsuya
