On Tue, Jun 28, 2016 at 02:17:41PM +0800, Jianbo Liu wrote: > On 27 June 2016 at 19:54, Jerin Jacob <jerin.jacob at caviumnetworks.com> > wrote: > > split out SSE instruction based virtio simple rx > > implementation to a separate file > > > > Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com> > > --- > > drivers/net/virtio/virtio_rxtx_simple.c | 166 +------------------- > > drivers/net/virtio/virtio_rxtx_simple_sse.h | 225 > > ++++++++++++++++++++++++++++ > > 2 files changed, 226 insertions(+), 165 deletions(-) > > create mode 100644 drivers/net/virtio/virtio_rxtx_simple_sse.h > > > I think it's better to move sse implementation to a C file, > as Bruce pointed out at > http://www.dpdk.org/ml/archives/dev/2016-April/037937.html
I can move to C file, That would call for further restructuring of the code by Introducing a new file drivers/net/virtio/virtio_rxtx_simple.h and moving all static inline functions of virtio_rxtx_simple.c so that virtio_rxtx_simple_sse.c and virtio_rxtx_simple_neon.c can include it. Huawei,Yuanhan,All, Are you OK with above restructuring? Jerin > > Jianbo
