On Mon, Jun 27, 2016 at 04:19:57PM +0200, Thomas Monjalon wrote: > 2016-06-27 17:24, Jerin Jacob: > > --- a/config/common_base > > +++ b/config/common_base > > @@ -267,6 +267,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n > > +CONFIG_RTE_LIBRTE_VIRTIO_INC_VECTOR=y > > I don't remember what means INC_VECTOR? > Why a config option is needed for vector implementations?
I thought of adding additional configuration option(INC_VECTOR) _apart_ from cpu flag based scheme in the patch because even though if a given platform has cpu instruction support, in some platforms scalar version may perform well wrt vector version(based on instruction latency, emulation required or not etc). So a top level flag INC_VECTOR, can override the vector selection for a given platform if required. Regarding INC_VECTOR(INC in vector configuration name, I have no idea, I followed the existing flags) $ grep "INC_VECTOR" config/common_base CONFIG_RTE_IXGBE_INC_VECTOR=y CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y Jerin
