On Fri, Jan 29, 2016 at 12:47 PM, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote: > Two minor nits. > > Firstly about your title, you should be consistent: sometimes you > use virtio_pci, and sometimes you use virtio_pic.h. And for virtio > pmd driver, "virtio: " prefix is pretty enough, no need another > extra "vfio: " or "pci: " prefix. > > And the same to your EAL changes. EAL is a bigger, having more > components, thus sometimes 2 prefixs are used. And if you are > not sure how to add prefix, dig the git history to get the answer. > > On Tue, Jan 19, 2016 at 05:16:10PM +0530, Santosh Shukla wrote: >> If virtio interface attached to vfio-noiommu driver then >> do not parse for virtio resource. Instead exit with return 0; >> >> Note: Applicable for virtio spec 0.95. > > And this is not necessary: io port stuff is for virtio 0.95 only. > virtio 1.0 won't use that, at all. >
Okay, I removed [08/11] patch from v5 series and modified this patch accordingly [1]. So, ignore this patch and pl. review provided link. [1] http://dpdk.org/dev/patchwork/patch/10143/ > --yliu
