> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Saturday, November 16, 2024 1:37 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <step...@networkplumber.org>;
> jerin.ja...@caviumnetworks.com; Richardson, Bruce
> <bruce.richard...@intel.com>; Gujjar, Abhinandan S
> <abhinandan.guj...@intel.com>
> Subject: [PATCH v3 04/10] app/test: avoid duplicate initialization
>
> The event_dev_config initialization had duplicate assignments to the same
> element. Change to use structure initialization so that compiler will catch
> this
> type of bug.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")
> Cc: jerin.ja...@caviumnetworks.com
>
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
Acked-by: Abhinandan Gujjar <abhinandan.guj...@intel.com>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
> app/test/test_event_crypto_adapter.c | 24 ++++++++++--------------
> 1 file changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 9d38a66bfa..ab24e30a97 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -1154,21 +1154,17 @@ configure_cryptodev(void)
>
> static inline void
> evdev_set_conf_values(struct rte_event_dev_config *dev_conf,
> - struct rte_event_dev_info *info)
> + const struct rte_event_dev_info *info)
> {
> - memset(dev_conf, 0, sizeof(struct rte_event_dev_config));
> - dev_conf->dequeue_timeout_ns = info->min_dequeue_timeout_ns;
> - dev_conf->nb_event_ports = NB_TEST_PORTS;
> - dev_conf->nb_event_queues = NB_TEST_QUEUES;
> - dev_conf->nb_event_queue_flows = info->max_event_queue_flows;
> - dev_conf->nb_event_port_dequeue_depth =
> - info->max_event_port_dequeue_depth;
> - dev_conf->nb_event_port_enqueue_depth =
> - info->max_event_port_enqueue_depth;
> - dev_conf->nb_event_port_enqueue_depth =
> - info->max_event_port_enqueue_depth;
> - dev_conf->nb_events_limit =
> - info->max_num_events;
> + *dev_conf = (struct rte_event_dev_config) {
> + .dequeue_timeout_ns = info->min_dequeue_timeout_ns,
> + .nb_event_ports = NB_TEST_PORTS,
> + .nb_event_queues = NB_TEST_QUEUES,
> + .nb_event_queue_flows = info->max_event_queue_flows,
> + .nb_event_port_dequeue_depth = info-
> >max_event_port_dequeue_depth,
> + .nb_event_port_enqueue_depth = info-
> >max_event_port_enqueue_depth,
> + .nb_events_limit = info->max_num_events,
> + };
> }
>
> static int
> --
> 2.45.2
