On Mon, Mar 4, 2024 at 7:45 PM Stephen Hemminger <step...@networkplumber.org> wrote: > > This reverts commit 07d836e5929d18ad6640ebae90dd2f81a2cafb71. > > Tyler found build issues with MSVC and the thash gfni stubs. > The problem would be link errors from missing symbols.
Trying to understand this link error. Does it come from the fact that rte_thash_gfni/rte_thash_gfni_bulk declarations are hidden under RTE_THASH_GFNI_DEFINED in rte_thash_gfni.h? If so, why not always expose those two symbols unconditionnally and link with the stub only when ! RTE_THASH_GFNI_DEFINED. -- David Marchand
