Hello Tyler,


since we are duplicating something that comes from something else that
has been duplicated out of windows WDK here it might be a reasonable
safety check to verify that our duplicated values match our
expectations?

MEM_COALESCE_PLACEHOLDERS, MEM_PRESERVE_PLACEHOLDER,
MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER
are defined in Win32 API.

DPDK has no expectations about these values. DPDK needs them as parameters to the VirtualX function calls. It looks like the macros were added to EAL because they were missing in mingw.

Once compiler environment was fixed, the proper order was restored.

Regards,
Gregory



#ifndef MEM_COALESCE_PLACEHOLDERS
#define MEM_COALESCE_PLACEHOLDERS 0x00000001
#else
static_assert(MEM_COALESCE_PLACEHOLDERS == 0x00000001, "...")
#endif

either way, this is straight forward.

Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>


Reply via email to