2023-11-14 19:05 (UTC+0200), Gregory Etelson: > Windows compilation with cross-mingw on Fedora 39 failed > because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were > already defined in the compiler environment: > > eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined > /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5710: note: > this is the location of the previous definition > > eal_memory.c:78: error: "MEM_RESERVE_PLACEHOLDER" redefined > /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5715: note: > this is the location of the previous definition > > The patch masks MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER > macros if they were pre-defined by compiler. > > The patch also masks MEM_COALESCE_PLACEHOLDERS and > MEM_PRESERVE_PLACEHOLDER to prevent similar errors. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > > Cc: sta...@dpdk.org > Signed-off-by: Gregory Etelson <getel...@nvidia.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com>