Hi,
> -----Original Message-----
> From: Alexander Kozyrev <akozy...@nvidia.com>
> Sent: Tuesday, July 18, 2023 4:32 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh <rasl...@nvidia.com>; Slava
> Ovsiienko <viachesl...@nvidia.com>; Matan Azrad <ma...@nvidia.com>;
> step...@networkplumber.org; Bing Zhao <bi...@nvidia.com>
> Subject: [PATCH v2 1/3] net/mlx5: fix validation for conntrack indirect action
>
> From: Bing Zhao <bi...@nvidia.com>
>
> After rte_flow_shared_action_* API was replaced with
> rte_flow_action_handle_* API, one input parameter of the update interface
> was also changed. A generic pointer was used instead of the "const struct
> rte_flow_action *" pointer.
>
> In the entrance of mlx5 PMD callback for update, the validation is called for
> all
> indirect actions. But for conntrack type, the pointer is no longer with
> rte_flow_action pointer type and it will cause an incorrect casting and error.
>
> The content for updating should only be validated when needed. It should skip
> the validation in the entrance. Right now, the content was already added
> before updating the hardware by WQE. So the type of the indirect action
> should be checked before calling the action validate function.
>
> When creating a new conntrack object, the validation is still needed since all
> the content will be used to update the hardware context.
>
> Fixes: 40327aab1491 ("ethdev: introduce indirect flow action")
>
> Signed-off-by: Bing Zhao <bi...@nvidia.com>
Series applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
