On Fri, 17 Mar 2023 17:20:59 +0100 Olivier Matz <olivier.m...@6wind.com> wrote:
> On Wed, Mar 15, 2023 at 10:31:32AM -0700, Stephen Hemminger wrote: > > The setting in terminal handling for both Unix style and > > Windows was not ensuring that Ctrl-C character would > > cause interrupt. > > > > This is a first release bug. Testpmd interactive mode has > > always disabled control-c handling on Linux. > > This was a design choice, not a bug. This design choice is discussable > today (at that time, dpdk was also running in baremetal without signals > or interrupt). The idea was to behave like a shell, i.e. ctrl-c just > clears the current line. > > We may want to change this behavior (I remember an old discussion where > Bruce stated that he would prefer ctrl-c to kill the program), but it > will have an impact on all cmdline users, so to me it has to be > announced. Ok, my motivation was to be able to test interrupt in testpmd interactive mode. Without this change, it requires sending SIGINT from another process. Plus almost all programs that have an interactive mode accept control-c to interrupt. I split this patch off since it doesn't impact the bugfix around testpmd and interrupts.
