On Tue, 14 Mar 2023 10:36:45 -0700 Stephen Hemminger <step...@networkplumber.org> wrote:
> Resolve issues around using control-C in testpmd. > Using cmdline_poll() is broken and won't work right so > don't use it. Instead use cmdline_interact() and fix > the signal handling. > > Stephen Hemminger (3): > testpmd: go back to using cmdline_interact > testpmd: use sig_atomic_t for flag > testpmd: enable interrupt in interactive mode > > app/test-pmd/cmdline.c | 27 ++++++++++++++------------- > app/test-pmd/testpmd.c | 17 ++++++++++++----- > app/test-pmd/testpmd.h | 3 ++- > lib/cmdline/cmdline.h | 10 ++++++++++ > lib/cmdline/cmdline_os_unix.c | 8 +++++++- > lib/cmdline/cmdline_os_windows.c | 18 ++++++++++++++++-- > lib/cmdline/cmdline_private.h | 2 +- > lib/cmdline/version.map | 3 +++ > 8 files changed, 65 insertions(+), 23 deletions(-) > This patch is failing the CI tests from something that seems unrelated. Looks like recent cyrptodev or ixgbe change broke something. -Idrivers/net/ice/base -I../drivers/net/ice/base -Idrivers/net/ice/../../common/iavf -I../drivers/net/ice/../../common/iavf -Idrivers/common/iavf -I../drivers/common/iavf -Idrivers/net/mlx5 -I../drivers/net/mlx5 -Idrivers/net/mlx5/linux -I../drivers/net/mlx5/linux -Idrivers/net/mlx5/hws -I../drivers/net/mlx5/hws -Idrivers/common/mlx5 -I../drivers/common/mlx5 -Idrivers/common/mlx5/linux -I../drivers/common/mlx5/linux -Idrivers/bus/auxiliary -I../drivers/bus/auxiliary -I/usr/include/libnl3 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototyp es -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE -march=armv8-a+crc+crypto -march=armv8-a+crc -moutline-atomics -DALLOW_EXPERIMENTAL_API -Wno-deprecated-declarations -MD -MQ 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o' -MF 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o.d' -o 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o' -c ../drivers/net/ixgbe/ixgbe_testpmd.c In file included from ../drivers/net/ixgbe/ixgbe_ethdev.h:11, from ../drivers/net/ixgbe/ixgbe_testpmd.c:9: ../drivers/net/ixgbe/base/ixgbe_type.h:2945:17: error: conflicting types for 'u64' 2945 | #define __le64 u64 | ^~~ In file included from ../drivers/net/ixgbe/base/ixgbe_type.h:46, from ../drivers/net/ixgbe/ixgbe_ethdev.h:11, from ../drivers/net/ixgbe/ixgbe_testpmd.c:9: ../drivers/net/ixgbe/base/ixgbe_osdep.h:94:18: note: previous declaration of 'u64' was here 94 | typedef uint64_t u64; | ^~~ [2968/3157] Compiling C object 'app/test/3062f5d@@dpdk-test@exe/test_alarm.c.o'. [2969/3157] Compiling C object 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_mlx5_mlx5_testpmd.c.o'. [2970/3157] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk@sta/event_cnxk_tx_cn10k_tx_112_127_seg.c.o'. ninja: build stopped: subcommand failed. ==== End log output ====