On Mon, Nov 28, 2022 at 06:22:10PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Monday, 28 November 2022 18.14 > > > > On Thu, Nov 24, 2022 at 11:17:23AM +0100, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > > Sent: Thursday, 24 November 2022 00.43 > > > > > > > > Provide an abstraction for leading and trailing zero bit counting > > > > functions to hide compiler specific intrinsics and builtins. > > > > > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > > > --- > > > > > > > let me unpack what is being asked for here. > > > > > Related functions already exist in lib/eal/include/rte_common.h. > > > > i don't understand. are you saying these inline functions duplicate > > existing bit counting functionality? if so i'll relocate any you > > identify. > > Sorry about not being clear about my intentions with the feedback. > > I'm not asking for anything; I only wanted to point at the similar family of > functions in rte_common.h, to make sure that you were aware of them.
oh! not a problem. i'm very keen to catch any mistakes, thought i had missed something. > > > > > > > > > If some functions are missing, it would be good to add them. > > > > the change here is to address a specific family of functions that are > > impeding portability of the rte_common.h header and nothing more. > > > > i'm open to having a separate mail thread discussing what other > > functions we might want and whether to relocate code out of > > rte_common.h > > since that is likely to be a drawn out discussion it shouldn't be a > > blocking dependency of this series. > > I do not request any new functions; I'll leave it up to you to decide if > anything would be good to add. > > > > > > > > > Also, it makes sense moving them out of rte_common.h. > > > > thanks! > > Thank you! Cleaning up is always appreciated. yes, if i can get more rapid approvals there is a lot more in the pipeline. i'd like gain some momentum if possible. ty
