On Thu, Nov 24, 2022 at 11:17:23AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 24 November 2022 00.43 > > > > Provide an abstraction for leading and trailing zero bit counting > > functions to hide compiler specific intrinsics and builtins. > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > --- >
let me unpack what is being asked for here. > Related functions already exist in lib/eal/include/rte_common.h. i don't understand. are you saying these inline functions duplicate existing bit counting functionality? if so i'll relocate any you identify. > > If some functions are missing, it would be good to add them. the change here is to address a specific family of functions that are impeding portability of the rte_common.h header and nothing more. i'm open to having a separate mail thread discussing what other functions we might want and whether to relocate code out of rte_common.h since that is likely to be a drawn out discussion it shouldn't be a blocking dependency of this series. > > Also, it makes sense moving them out of rte_common.h. thanks!
