Masking of core mask was incorrect. Instead of using 1U for shifting, it
should be using 1LU as the result is assigned to uint64.
CID 375859: Potentially overflowing expression "1U << app_main_core" with
type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit
arithmetic, and then used in a context that expects an expression of
type "uint64_t" (64 bits, unsigned).
Coverity issue: 375859
Signed-off-by: Megha Ajmera <megha.ajm...@intel.com>
---
examples/qos_sched/args.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 10ca7bea61..562d9ca150 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -427,13 +427,13 @@ app_parse_args(int argc, char **argv)
/* check main core index validity */
for (i = 0; i <= app_main_core; i++) {
- if (app_used_core_mask & (1u << app_main_core)) {
+ if (app_used_core_mask & (RTE_BIT64(app_main_core))) {
RTE_LOG(ERR, APP, "Main core index is not configured
properly\n");
app_usage(prgname);
return -1;
}
}
- app_used_core_mask |= 1u << app_main_core;
+ app_used_core_mask |= RTE_BIT64(app_main_core);
if ((app_used_core_mask != app_eal_core_mask()) ||
(app_main_core != rte_get_main_lcore())) {
--
2.25.1
