Hi Akhil,
Akhil Goyal <gak...@marvell.com> writes: > Hi Fan, >> Hi Akhil, >> >> I assume everything in asym crypto is under experimental tag at the moment >> right? >> The goal is to have them updated and fixed before DPDK 22.11 so the >> experimental tag can be removed. >> > Asymmetric crypto APIs are marked as experimental, but the structures are not > explicitly marked experimental. > rte_crypto_asym_op is part of union in rte_crypto_op which is definitely not > experimental. > So a change in asym_op will result in ABI issues in rte_crypto_op. > > David/Ray: Can you review the patch 1/4 of this series from ABI compatibility > point of view. > http://patches.dpdk.org/project/dpdk/patch/20220207113555.8431-2-arkadiuszx.kusz...@intel.com/ > IMO, as per current experimental tags, we cannot change parameters inside > rte_crypto_asym_op > and subsequently in struct rte_crypto_dsa_op_param. What do you suggest? > However, I remember, some exception was added to ignore ABI issues related to > asymmetric > crypto. Could you please check why that exception is not working in this case? > > Regards, > Akhil So rte_crypto_asym_op is at the end of the rte_crypto_op struct, so any changes there are safe. http://mails.dpdk.org/archives/test-report/2022-February/257617.html The warning above is complaining about changes to rte_crypto_asym_op. IMHO it is safe to condone these warnings in the libabigail.ignore. libabigail.ignore exceptions was reset at the 21.11 release, although I took a look and don't see anything related to asymmetric crypto prior to that. -- Regards, Ray K
