Hi Akhil, I assume everything in asym crypto is under experimental tag at the moment right? The goal is to have them updated and fixed before DPDK 22.11 so the experimental tag can be removed.
Regards, Fan > -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Thursday, February 10, 2022 10:17 AM > To: Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com>; dev@dpdk.org > Cc: Zhang, Roy Fan <roy.fan.zh...@intel.com>; Ramkumar Balu > <rb...@marvell.com> > Subject: RE: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, > add crypto uint > > > This patch adds crypto uint typedef so adding comment > > about byte-order becomes unnecessary. > > > > It makes API comments more tidy, and more consistent > > with other asymmetric crypto APIs. > > > > Additionally it reorganizes code that enums, externs > > and forward declarations are moved to the top of the > > header file making code more readable. > > > > It removes also comments like co-prime constraint > > from mod inv as it is natural mathematical constraint, > > not PMD constraint. > > > > Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com> > > --- > CI is reporting abi issues in this set. Can you check? > http://mails.dpdk.org/archives/test-report/2022-February/257403.html