Jerin Jacob <jerinjac...@gmail.com> writes:
> On Thu, Dec 9, 2021 at 12:30 AM Jie Zhou <j...@linux.microsoft.com> wrote:
>>
>> Even though test_interrupts.c can compile on Windows, skip interrupt
>> tests for now since majority of eal_interrupt on Windows are stubs.
>> Will remove the skip after interrupt being fully enabled on Windows.
>>
>> Signed-off-by: Jie Zhou <j...@linux.microsoft.com>
>> Acked-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com>
>>
>> ---
>> app/test/test_interrupts.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/app/test/test_interrupts.c b/app/test/test_interrupts.c
>> index 2a05399f96..eec9b2805b 100644
>> --- a/app/test/test_interrupts.c
>> +++ b/app/test/test_interrupts.c
>> @@ -12,6 +12,15 @@
>>
>> #include "test.h"
>>
>> +#ifdef RTE_EXEC_ENV_WINDOWS
>
> Across the series,
> Instead of adding conditional compilation everywhere, Why not disable
> specific file
> for compilation for windows?
> Purpose of EAL to abstract the differences in execution environment
> and application
> should not know that.
I think this was done because there would be two test lists in the meson
unit test file. But this is the second comment about these ifdef's, and
maybe we should revisit that discussion. Is there a different way to
accomplish not running the tests which are not appropriate for windows
builds, while not having two overlapping lists of unit tests in the
meson build file?
>> +static int
>> +test_interrupt(void)
>> +{
>> + printf("Interrupt on Windows is not fully supported yet, skipping
>> test\n");
>> + return TEST_SKIPPED;
>> +}
>> +#else
>> +
>> #define TEST_INTERRUPT_CHECK_INTERVAL 100 /* ms */
>>
>> /* predefined interrupt handle types */
>> @@ -590,5 +599,6 @@ test_interrupt(void)
>>
>> return ret;
>> }
>> +#endif /*ifdef RTE_EXEC_ENV_WINDOWS*/
>>
>> REGISTER_TEST_COMMAND(interrupt_autotest, test_interrupt);
>> --
>> 2.31.0.vfs.0.1
>>
