29/10/2021 20:53, David Marchand:
> On Fri, Oct 29, 2021 at 7:17 PM Jim Harris <james.r.har...@intel.com> wrote:
> >
> > clang-13 rightfully complains that the tot_ppi
> > variable in update_stats is set but not used, since
> > the final accumulated tot_ppi results isn't used
> > anywhere. So just remove the tot_ppi variable.
>
> Dead code, from the start...
> Fixes: 450f0791312c ("power: add traffic pattern aware power control")
>
> > @@ -237,7 +237,6 @@ update_stats(struct priority_worker *poll_stats)
> >
> > for (j = 0; j < BINS_AV; j++) {
> > tot_edpi += s->edpi_av[j];
> > - tot_ppi += s->ppi_av[j];
> > }
>
> I don't think keeping ppi_av[] (and related data struct) is that
> useful.. but in any case patch lgtm:
>
> Reviewed-by: David Marchand <david.march...@redhat.com>
I understand that a v2 removing ppi_av would be better.
