Thanks Thomas.
Will update the following commit-log in patch v4

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en enabled.

When dv_xmeta_en enabled in legacy creating flow,
it will split into two flows (one set_tag with jump flow and one RSS/queue 
action flow).
For meter policy as termination table, it cannot split flow and cannot support
dv_xmeta_en enabled.


Regards,
Li Zhang

-----Original Message-----
From: Thomas Monjalon <tho...@monjalon.net> 
Sent: Tuesday, October 26, 2021 5:51 PM
To: Li Zhang <l...@nvidia.com>
Cc: Ori Kam <or...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com>; Matan 
Azrad <ma...@nvidia.com>; Shahaf Shuler <shah...@nvidia.com>; Shun Hao 
<sh...@nvidia.com>; dev@dpdk.org; Raslan Darawsheh <rasl...@nvidia.com>; Roni 
Bar Yanai <ron...@nvidia.com>; sta...@dpdk.org
Subject: Re: [PATCH v3] doc: document a limitation for a meter with RSS action

External email: Use caution opening links or attachments


26/10/2021 11:31, Li Zhang:
> A meter policy with RSS/Queue action is not supported when dv_xmeta_en 
> is not zero.

It is still not explaining why.

>
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Li Zhang <l...@nvidia.com>
> Acked-by: Matan Azrad <ma...@nvidia.com>
> ---
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
>    - Policy actions of RSS for green and yellow should have the same 
> configuration except queues.
> +  - Policy with RSS/queue action is not supported when dv_xmeta_en is not 
> zero.

It is still not enclosed like this: ``dv_xmeta_en``

Don't you think "enabled" is better than "not zero"?



Reply via email to