Thanks!
I will update it into patch v6 according to your comments.
Please take a look.
Regards,
Li Zhang
-----Original Message-----
From: Thomas Monjalon <tho...@monjalon.net>
Sent: Tuesday, October 26, 2021 8:28 PM
To: Li Zhang <l...@nvidia.com>; Raslan Darawsheh <rasl...@nvidia.com>
Cc: Ori Kam <or...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com>; Matan
Azrad <ma...@nvidia.com>; Shahaf Shuler <shah...@nvidia.com>; Shun Hao
<sh...@nvidia.com>; dev@dpdk.org; Roni Bar Yanai <ron...@nvidia.com>;
sta...@dpdk.org
Subject: Re: [PATCH v5] doc: document a limitation for a meter with RSS action
External email: Use caution opening links or attachments
The title should mention "mlx5 guide" as the scope.
26/10/2021 13:53, Li Zhang:
> A meter policy with RSS/Queue action is not supported when
> ``dv_xmeta_en`` enabled.
The quotes are RST syntax.
Raslan, while merging, you can remove the quotes from the commit log.
>
> When ``dv_xmeta_en`` enabled in legacy creating flow, it will split
> into two flows (one set_tag with jump flow and one RSS/queue action
> flow).
> For meter policy as termination table, it cannot split flow and cannot
> support when ``dv_xmeta_en`` enabled.
>
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Li Zhang <l...@nvidia.com>
> Acked-by: Matan Azrad <ma...@nvidia.com>
> ---
> doc/guides/nics/mlx5.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
> 47709d93b3..cd28c04c1e 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -435,6 +435,7 @@ Limitations
> - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and
> SET_TAG.
> - RED: must be DROP.
> - Policy actions of RSS for green and yellow should have the same
> configuration except queues.
> + - Policy with RSS/queue action is not supported when ``dv_xmeta_en``
> enabled.
> - meter profile packet mode is supported.
> - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
