Hi Dmitry. > -----Original Message----- > From: Dmitry Kozlyuk <dkozl...@nvidia.com> > Sent: Sunday, October 17, 2021 12:15 PM > Subject: RE: [PATCH v2 2/5] ethdev: add capability to keep shared objects on > restart > > > [...] > > > +By default it is unspecified if indirect actions persist after the > > device stop. > > > +If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is not advertised, > > > +then indirect actions must be explicitly destroyed before stopping > > > +the device if the application needs to ensure they are removed. > > > > I don't understand the above line, if indirect actions must be > > explicitly destroyed what does it means "if the application needs to > > ensure?) I think it should say just like now, application should > > destroy all shared objects before stopping. If application doesn't > > call the destroy the state of the action is undefined. > > I had in mind that some applications don't care, because they only stop the > port before closing it. > Would the following be more explicit? > > "If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is not advertised, the state > of indirect > actions after the device stop is undefined. > Application must destroy all indirect actions before stopping the port if it > intends to start it later, or > unwanted indirect actions can remain."
Sounds better, but I would also add something like this: if PMD doesn''t report keep, application should release resource before stopping / closing the port otherwise resource leak may happen. This should also be in the flows patch. Best, Ori
