On 9/17/2021 12:55 PM, David Marchand wrote:
> Hi Chenbo,
>
> On Fri, Sep 17, 2021 at 5:09 AM Xia, Chenbo <chenbo....@intel.com> wrote:
>>>> PCI ID and address in structure rte_kni_conf are never used and
>>>> will be removed in kni library. So remove the setting of them
>>>> first in the example.
>>>>
>>>> Signed-off-by: Chenbo Xia <chenbo....@intel.com>
>>>
>>> (forgot to Cc: Ferruh in previous comment)
>>> Ditto patch 5.
>>>
>>> I would tag with a Fixes: on ethtool removal.
>>> Plus, this is the same kind of cleanup wrt kni, you can squash those
>>> two patches together.
>>
>> A question about squash patch 5 and 6, then how should I title the combined
>> patch? Because there're both test change and example change. I'd like know
>> your suggestion.
>>>
>
> This is a cleanup on unused fields wrt KNI.
> "kni: remove unused PCI info from test and example" lgtm.
>
> Ferruh, opinion?
>
Make sense to merge them and above suggestion looks good. Thanks.
> And mark with:
> Fixes: ea6b39b5b847 ("kni: remove ethtool support")
>
>
