Hi David, > -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Friday, September 10, 2021 3:18 PM > To: Xia, Chenbo <chenbo....@intel.com> > Cc: dev <dev@dpdk.org>; Dumitrescu, Cristian <cristian.dumitre...@intel.com>; > Yigit, Ferruh <ferruh.yi...@intel.com> > Subject: Re: [dpdk-dev] [PATCH 6/8] examples/ip_pipeline: remove setting of > PCI ID and address > > On Fri, Sep 10, 2021 at 4:38 AM Chenbo Xia <chenbo....@intel.com> wrote: > > > > PCI ID and address in structure rte_kni_conf are never used and > > will be removed in kni library. So remove the setting of them > > first in the example. > > > > Signed-off-by: Chenbo Xia <chenbo....@intel.com> > > (forgot to Cc: Ferruh in previous comment) > Ditto patch 5. > > I would tag with a Fixes: on ethtool removal. > Plus, this is the same kind of cleanup wrt kni, you can squash those > two patches together.
OK. Will do. > > > Too bad we do not have a deprecation notice. > lib/kni/rte_kni.h: struct rte_pci_addr addr; /* depreciated */ > lib/kni/rte_kni.h: struct rte_pci_id id; /* depreciated */ > > Can we plan for this cleanup? My bad. I did't notice this when I send the deprecation notice for PCI bus last release. If we all agree, we can make this happen 22.11 (Or this release if tech-board agrees). Thanks, Chenbo > > > -- > David Marchand
