On Fri, Sep 10, 2021 at 4:38 AM Chenbo Xia <chenbo....@intel.com> wrote: > > PCI ID and address in structure rte_kni_conf are never used and > will be removed in kni library. So remove the setting of them > first in the example. > > Signed-off-by: Chenbo Xia <chenbo....@intel.com>
(forgot to Cc: Ferruh in previous comment) Ditto patch 5. I would tag with a Fixes: on ethtool removal. Plus, this is the same kind of cleanup wrt kni, you can squash those two patches together. Too bad we do not have a deprecation notice. lib/kni/rte_kni.h: struct rte_pci_addr addr; /* depreciated */ lib/kni/rte_kni.h: struct rte_pci_id id; /* depreciated */ Can we plan for this cleanup? -- David Marchand