On Sun, Jul 11, 2021 at 3:12 PM fengchengwen <fengcheng...@huawei.com> wrote: > > Note: > 1) This patch hold dmadev <> vchan layer, I think vchan can be very > conceptually separated from hw-channel.
I would like to keep it as channel instead of virtual channel as it is implementation-specific. No strong opinion on this? @Richardson, Bruce @Morten Brørup thoughts > 2) I could not under struct dpi_dma_queue_ctx_s, so this patch I define > the rte_dma_slave_port_parameters refer to Kunpeng DMA implemention. > 3) This patch hasn't include doxy related file because failed to generate > a doc in my environment, could this upstream as a new patch or must > solved ? No IMO. The final version needs to be merged to should have split patch-like, 1) Header file with doxygen comments 2) Multiple patches for implementation as needed 3) Programmer guide doc Other items, Typically we will have per new device class. 1) Skelton driver(can use memcpy in this case) 2) app/test-dmadev kind of application.(Can be used to measure performance and functionality) > > Feedback welcome, thanks > > On 2021/7/11 17:25, Chengwen Feng wrote: > > This patch introduce 'dmadevice' which is a generic type of DMA > > device. > > > > The APIs of dmadev library exposes some generic operations which can > > enable configuration and I/O with the DMA devices. > > > > Signed-off-by: Chengwen Feng <fengcheng...@huawei.com> > > --- >
