> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Tuesday, July 6, 2021 21:28 > To: Wang, Haiyue <haiyue.w...@intel.com> > Cc: dev@dpdk.org; sta...@dpdk.org; Yang, Qiming <qiming.y...@intel.com>; > Zhang, Qi Z > <qi.z.zh...@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell...@intel.com> > Subject: Re: [PATCH] net/ice: fix memzone leak when firmware is missing > > On Tue, Jul 6, 2021 at 2:53 PM Wang, Haiyue <haiyue.w...@intel.com> wrote: > > > > The function 'ice_deinit_hw' should be used. ;-) > > > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ice > > > /ice_main.c#n4508 > > > > > > Well I was inspired by ice_dev_close(), so I guess this code too could > > > use some cleanup but I don't have the hw anymore to test this change. > > > I'll trust you and simply update ice_dev_init. > > Adding to this, there are other potential leaks if ice_flow_init() or > ice_reset_fxp_resource() fails. > Probably worth opening a bz for later processing. > WDYT?
Yeah, make sense. ;-) > > > -- > David Marchand
