On Tue, Jul 6, 2021 at 2:53 PM Wang, Haiyue <haiyue.w...@intel.com> wrote: > > > The function 'ice_deinit_hw' should be used. ;-) > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ice > > /ice_main.c#n4508 > > > > Well I was inspired by ice_dev_close(), so I guess this code too could > > use some cleanup but I don't have the hw anymore to test this change. > > I'll trust you and simply update ice_dev_init.
Adding to this, there are other potential leaks if ice_flow_init() or ice_reset_fxp_resource() fails. Probably worth opening a bz for later processing. WDYT? -- David Marchand