On Thu, Jun 10, 2021 at 12:30 PM Kevin Traynor <ktray...@redhat.com> wrote: > > On 10/06/2021 11:05, Christian Ehrhardt wrote: > > On Thu, Jun 10, 2021 at 11:05 AM Ali Alnubani <alia...@nvidia.com> wrote: > >> > >> Hi Christian, > >> > >>> -----Original Message----- > >>> From: Christian Ehrhardt <christian.ehrha...@canonical.com> > >>> Sent: Thursday, June 10, 2021 11:49 AM > >>> To: dpdk stable <sta...@dpdk.org> > >>> Cc: dev <dev@dpdk.org>; Abhishek Marathe > >>> <abhishek.mara...@microsoft.com>; Akhil Goyal <akhil.go...@nxp.com>; > >>> Ali Alnubani <alia...@nvidia.com>; Walker, Benjamin > >>> <benjamin.wal...@intel.com>; David Christensen > >>> <d...@linux.vnet.ibm.com>; Govindharajan, Hariprasad > >>> <hariprasad.govindhara...@intel.com>; Hemant Agrawal > >>> <hemant.agra...@nxp.com>; Ian Stokes <ian.sto...@intel.com>; Jerin > >>> Jacob <jer...@marvell.com>; John McNamara <john.mcnam...@intel.com>; > >>> Ju-Hyoung Lee <juh...@microsoft.com>; Kevin Traynor > >>> <ktray...@redhat.com>; Luca Boccassi <bl...@debian.org>; Pei Zhang > >>> <pezh...@redhat.com>; Yu, PingX <pingx...@intel.com>; Xu, Qian Q > >>> <qian.q...@intel.com>; Raslan Darawsheh <rasl...@nvidia.com>; NBU- > >>> Contact-Thomas Monjalon <tho...@monjalon.net>; Peng, Yuan > >>> <yuan.p...@intel.com>; Chen, Zhaoyan <zhaoyan.c...@intel.com> > >>> Subject: Re: [dpdk-dev] 19.11.9 patches review and test - V2 > >>> > >>> On Fri, Jun 4, 2021 at 7:52 AM Christian Ehrhardt > >>> <christian.ehrha...@canonical.com> wrote: > >>>> > >>>> Hi all, > >>>> > >>>> Here is version 2 of the list of patches targeted for stable release > >>>> 19.11.9. > >>>> Thanks to plenty of helpful developers we've collected a few more > >>>> backports by now and sorted out a few rare compile time issues that were > >>> found with -rc1. > >>>> > >>>> The planned date for the final release of 19.11.9 is now 18th of June. > >>>> > >>>> Please help with testing and validation of your use cases and report > >>>> any issues/results with reply-all to this mail. For the final release > >>>> the fixes and reported validations will be added to the release notes. > >>>> > >>>> A release candidate tarball can be found at: > >>>> > >>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.9-rc2 > >>> > >>> Unfortunately there were further build issues with new suse kernels. > >>> The fix for some of them, now breaks others :-/ The final fix didn't > >>> finalize > >>> yet, but as a TL;DR it means there will be a -rc3 down the road. > >>> > >>> I beg your pardon for the extra work. > >>> If you are testing non-suse and are already deep into the tests you > >>> likely can > >>> continue that. > >>> If you didn't start your tests yet then I'd recommend holding back until > >>> -rc3 > >>> exists. > >>> > >> > >> I see some build failures with gcc 11. Do we expect this release to > >> support it? > > > > I have added all that were targeted at stable@dpdk, but I remember > > that Kevin mentioned a few missing in 20.11.x due to the submissions > > missing to go to stable@dpdk. > > The same could be the case here. > > @Kevin could you have a look at 19.11 and if there are some missing > > point me to the commits to pick up? > > > > @Ali - if you have a particular bug signature that might help to > > identify the right patch. > > > > They will all note 'GCC' (or gcc) in the commit msg. Most will have an > example of the 'warning' they resolved too. There was also bugzillas > opened for them all i think, which note the fixing commit. So if you > find any issues when building, you could cross-reference between warning > in commit/warning in Bz and fixing commit. Of course there may be some > new issues pop up in older code that was later changed/replaced in main. > > There was also 2 commits needed for clang 12 support (my bad for missing > tags on these). > 5ac070cfed test/cmdline: silence clang 12 warning > 414245bbc5 test/cmdline: fix inputs array
Compiler patches in main: I've rechecked all those to see why they were missing (if they did) to find if anything else is missing as well. GCC: 71acf81bf7 doc: add GCC 11 and clang 12 support to release notes - not targetted at stable (ok to be missing) 50eea2bfa7 test: fix build with GCC 11 - this got all missed due to the same problem Xueming had reported 099db3d156 crypto/zuc: fix build with GCC 11 - fixed code is only in 20.05 8f73a72378 test/crypto: fix build with GCC 11 33c12ac5ba test/table: fix build with GCC 11 a625ab89df net/tap: fix build with GCC 11 97de3819ed net/ice/base: fix build with GCC 11 ab70be7e2d net/bnx2x: fix build with GCC 11 b3c740e037 net/bnx2x: fix build with GCC 11 - these got all missed due to the same problem Xueming had reported 8e2dd74f0a acl: fix build with GCC 11 - I've seen this one but it fixes code that is only in 20.11 Clang: 5ac070cfed test/cmdline: silence clang 12 warning 414245bbc5 test/cmdline: fix inputs array Those two just were not tagged, that is fine and they will be added this round. I was able to identify quite a few more affected by the same issue So I thank you a lot for pushing on this! > >> I also see some doxygen errors with version 1.9.1 in Fedora Rawhide. Will > >> open a Bugzilla ticket. > > > > Rawhide builds of 19.11.x were broken for a while now, but yeah filing > > the bug surely is the right path. > > > >> Thanks, > >> Ali > > > > > > > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd