On Tue, Apr 27, 2021 at 11:17:24PM +0000, Honnappa Nagarahalli wrote: <snip> > Yes, this is what we have done. It is a new forwarding mode. > We could remove some forwarding modes from testpmd. For ex: macfwd, macswap > seem very similar to iofwd mode.
I'd suggest removing one of those two, but not both. Sometimes one is testing with a system behind a switch where correct mac addresses need to be used to ensure proper packet return. > > > > > In fact, l3fwd is also quite big and complex: > > $ wc -l examples/l3fwd/*.[h,c] |grep total > > 6969 total > > > > Plus it will introduce extra dependencies (fib, lpm, hash, might-be acl?) I > > am > > not sure it is a good idea to pull all these complexities into test-pmd. > I do not suggest pulling all these in. In our case, I see that the ask is > only on LPM. I am open to hearing what others see as the requirement. > I think fib is the planned long-term replacement for lpm, and implements the same algorithm, so I think first versions should use it.
