From:Ferruh Yigit <ferruh.yi...@intel.com> To:humin (Q) <humi...@huawei.com>;dev <dev@dpdk.org> Date:2021-04-27 21:47:08 Subject:Re: [dpdk-dev] [PATCH 6/6] net/hns3: fix vector Rx burst default value
On 4/26/2021 4:34 AM, Min Hu (Connor) wrote: > From: Chengwen Feng < fengcheng...@huawei.com<mailto:fengcheng...@huawei.com>> > > Currently, driver uses the macro HNS3_DEFAULT_RX_BURST whose value is > 32 to limit the vector Rx burst size, as a result, the burst size user > configure can't exceed 32. > > This patch fixes this problem by defining the macro > HNS3_DEFAULT_RX_BURST as 64. > > Fixes: a3d4f4d291d7 ("net/hns3: support NEON Rx") > Cc: sta...@dpdk.org<mailto:sta...@dpdk.org> > > Signed-off-by: Chengwen Feng < > fengcheng...@huawei.com<mailto:fengcheng...@huawei.com>> > Signed-off-by: Min Hu (Connor) < > humi...@huawei.com<mailto:humi...@huawei.com>> > --- > drivers/net/hns3/hns3_rxtx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3/hns3_rxtx.h > index 1e2e994..ba24e00 100644 > --- a/drivers/net/hns3/hns3_rxtx.h > +++ b/drivers/net/hns3/hns3_rxtx.h > @@ -20,7 +20,7 @@ > #define HNS3_DEFAULT_TX_RS_THRESH 32 > #define HNS3_TX_FAST_FREE_AHEAD 64 > > -#define HNS3_DEFAULT_RX_BURST 32 > +#define HNS3_DEFAULT_RX_BURST 64 It seems in the vector Rx path, the number of receive packets are limited silently to 'HNS3_DEFAULT_RX_BURST' independent from what user requested/configured. There can be driver/HW limitations to 'HNS3_DEFAULT_RX_BURST' that is OK, but instead of limiting user request, what do you think about Rx in the 'HNS3_DEFAULT_RX_BURST' blocks until user request justified? I mean something like following implementation: https://git.dpdk.org/dpdk/commit/?id=d96394ea263c sound good, will fix in v2, thanks
