On 4/27/2021 3:26 PM, Fengchengwen wrote: > > > *From:*Ferruh Yigit <ferruh.yi...@intel.com> > *To:*humin (Q) <humi...@huawei.com>;dev <dev@dpdk.org> > *Date:*2021-04-27 21:37:59 > *Subject:*Re: [dpdk-dev] [PATCH 1/6] net/hns3: delete some unused capabilities > > On 4/26/2021 4:34 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng < fengcheng...@huawei.com >> <mailto:fengcheng...@huawei.com>> >> >> This patch deletes some unused capabilities, include: >> 1. Delete some unused firmware capabilities definition. >> 2. Delete some unused driver capabilities definition. >> >> Signed-off-by: Chengwen Feng < fengcheng...@huawei.com >> <mailto:fengcheng...@huawei.com>> >> Signed-off-by: Min Hu (Connor) < humi...@huawei.com >> <mailto:humi...@huawei.com>> > > <...> > >> diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h >> index d27c725..de17878 100644 >> --- a/drivers/net/hns3/hns3_ethdev.h >> +++ b/drivers/net/hns3/hns3_ethdev.h >> @@ -855,17 +855,20 @@ enum { >> >> #define HNS3_DEVARG_DEV_CAPS_MASK "dev_caps_mask" >> >> -#define HNS3_DEV_SUPPORT_DCB_B 0x0 >> -#define HNS3_DEV_SUPPORT_COPPER_B 0x1 >> -#define HNS3_DEV_SUPPORT_UDP_GSO_B 0x2 >> -#define HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B 0x3 >> -#define HNS3_DEV_SUPPORT_PTP_B 0x4 >> -#define HNS3_DEV_SUPPORT_TX_PUSH_B 0x5 >> -#define HNS3_DEV_SUPPORT_INDEP_TXRX_B 0x6 >> -#define HNS3_DEV_SUPPORT_STASH_B 0x7 >> -#define HNS3_DEV_SUPPORT_RXD_ADV_LAYOUT_B 0x9 >> -#define HNS3_DEV_SUPPORT_OUTER_UDP_CKSUM_B 0xA >> -#define HNS3_DEV_SUPPORT_RAS_IMP_B 0xB >> +enum { >> + HNS3_DEV_SUPPORT_DCB_B, >> + HNS3_DEV_SUPPORT_COPPER_B, >> + HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B, >> + HNS3_DEV_SUPPORT_PTP_B, >> + HNS3_DEV_SUPPORT_TX_PUSH_B, >> + HNS3_DEV_SUPPORT_INDEP_TXRX_B, >> + HNS3_DEV_SUPPORT_STASH_B, >> + HNS3_DEV_SUPPORT_SIMPLE_BD_B, >> + HNS3_DEV_SUPPORT_RXD_ADV_LAYOUT_B, >> + HNS3_DEV_SUPPORT_OUTER_UDP_CKSUM_B, >> + HNS3_DEV_SUPPORT_RAS_IMP_B, >> + HNS3_DEV_SUPPORT_TM_B, >> +}; > > This cause some values to be changed, because of added/removed items, is this > expected? > If so can you please mention from this value change in the commit log, to > clarify. > > these values are used only in driver, so the order could adjust. > the commit log memtion it brifely, which is: > > 2. Delete some unused driver capabilities definition >
I am not talking about deletion of unused macros, Please mention that value of some of the macros have been changed and this is known and won't cause a problem.
