From:Ferruh Yigit <ferruh.yi...@intel.com> To:Fengchengwen <fengcheng...@huawei.com>;humin (Q) <humi...@huawei.com>;dev <dev@dpdk.org> Date:2021-04-27 22:26:09 Subject:Re: [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration
On 4/27/2021 3:15 PM, Fengchengwen wrote: > > > > > > *From:*Ferruh Yigit < ferruh.yi...@intel.com<mailto:ferruh.yi...@intel.com>> > *To:*humin (Q) < humi...@huawei.com<mailto:humi...@huawei.com>>;dev < > dev@dpdk.org<mailto:dev@dpdk.org>> > *Date:*2021-04-27 21:39:45 > *Subject:*Re: [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration > > On 4/26/2021 4:34 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng < >> fengcheng...@huawei.com<mailto:fengcheng...@huawei.com> < >> mailto:fengcheng...@huawei.com>> >> >> The rte flow interface does not support the API of the capability >> set. Therefore, fdir configuration logs are added to facilitate >> debugging. >> >> Signed-off-by: Chengwen Feng < >> fengcheng...@huawei.com<mailto:fengcheng...@huawei.com> < >> mailto:fengcheng...@huawei.com>> >> Signed-off-by: Min Hu (Connor) < >> humi...@huawei.com<mailto:humi...@huawei.com> < mailto:humi...@huawei.com>> >> --- >> drivers/net/hns3/hns3_fdir.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/drivers/net/hns3/hns3_fdir.c b/drivers/net/hns3/hns3_fdir.c >> index 87c1aef..8b14219 100644 >> --- a/drivers/net/hns3/hns3_fdir.c >> +++ b/drivers/net/hns3/hns3_fdir.c >> @@ -336,6 +336,8 @@ int hns3_init_fd_config(struct hns3_adapter *hns) >> BIT(INNER_IP_PROTO) | BIT(INNER_IP_TOS) | >> BIT(INNER_SRC_IP) | BIT(INNER_DST_IP) | >> BIT(INNER_SRC_PORT) | BIT(INNER_DST_PORT); >> + hns3_info(hw, "fdir tuple: inner<vlan_tag1 eth_type ip_src ip_dst " >> + "ip_proto ip_tos l4_src_port l4_dst_port>"); > > > If the messages are for debugging, what do you think about add them as > 'hns3_dbg'? Isn't info level too verbose for debugging? > > yes, it was used for debugging and log analyzing, we use hns3_info because the > default level may not debug in product scenario. > we use verbose readable log because it's useful for reading. > It is possible to dynamically change the log level and get debug logs when needed, I think this is better than enable it by default. OK, will fix in v2, thanks > thanks > > BTW: sorry for this reply format because using phone. >
