Hi Tal, 2021-04-18 19:04 (UTC+0000), Tal Shnaiderman: > > Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW > > > > External email: Use caution opening links or attachments > > > > > > 18/04/2021 19:08, Tal Shnaiderman: > > > the strncasecmp marco defined in rte_os_shim.h is already defined in > > > MinGW-w64, as a result the compiler prints out the warning below on > > > function redefinition whenever compiling a file including the header. > > > > > > ..\lib/librte_eal/windows/include/rte_os_shim.h:21: > > > warning: "strncasecmp" redefined > > > #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count) > > > > Why the tests are passing? Are we allowing warnings in build test? > > It's a good question, I see CI is passing without warnings, Dmitry can you > reproduce it? > > On my side the collision is with the following file: > > C:/mingw-w64/x86_64/mingw64/x86_64-w64-mingw32/include/string.h:119: note: > this is the location of the previous definition > #define strncasecmp _strnicmp > > I'm using: > -gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0 > -meson 0.53.2
I can't reproduce it using the same versions. Do you invoke meson with other options than "-Dexamples=..."?
