On Wed, 2020-12-16 at 13:52 +0000, Ferruh Yigit wrote: > On 12/16/2020 1:41 PM, Liron Himi wrote: > > -----Original Message----- > > From: Ferruh Yigit <ferruh.yi...@intel.com> > > Sent: Wednesday, 16 December 2020 15:37 > > To: Liron Himi <lir...@marvell.com> > > Cc: dev@dpdk.org; Luca Boccassi <bl...@debian.org>; Kevin Traynor > > <ktray...@redhat.com>; Akhil Goyal <akhil.go...@nxp.com> > > Subject: [EXT] Re: [PATCH v2] meson: update meson build for armada drivers > > > > External Email > > > > ---------------------------------------------------------------------- > > On 12/15/2020 10:23 PM, lir...@marvell.com wrote: > > > From: Liron Himi <lir...@marvell.com> > > > > > > With pkg-config support available within musdk library (from > > > musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' > > > can be removed. > > > PKG_CONFIG_PATH environment variable should be set appropriately to > > > use the musdk library. > > > > Hi Liron, > > > > It is good change to get rid of an custom meson option, can we or should we > > backport this to the v20.11? > > [L.H.] yes, it can be backported. > > > > Kevin, Luca, > > What do you think about backporting this patch to 19.11 & 20.11, it removes > 'lib_musdk_dir' custom meson config option and uses pkg-config to find the > musdk > libraries. > > It looks good change but not sure if it is a regression to remove a build > option. > > Thanks, > ferruh
I don't know how used it is, but removing a meson_option is no good for LTS. If there is no functionality/build breakage and it's 100% compatible, it could be made a no-op - that would be acceptable for me. -- Kind regards, Luca Boccassi
