> -----Original Message----- > From: Ferruh Yigit <[email protected]> > Sent: 2020年11月23日 17:57 > To: Zhang, Tianfei <[email protected]>; Jerin Jacob > <[email protected]>; Dumitrescu, Cristian <[email protected]>; > Hemant Agrawal <[email protected]>; Sachin Saxena > <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman > <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing > <[email protected]>; Xing, Beilei <[email protected]>; Nithin > Dabilpuram <[email protected]>; Ajit Khaparde > <[email protected]>; Raveendra Padasalagi > <[email protected]>; Vikas Gupta > <[email protected]>; Gagandeep Singh <[email protected]>; > Somalapuram Amaranath <[email protected]>; Akhil Goyal > <[email protected]>; Jay Zhou <[email protected]>; McDaniel, > Timothy <[email protected]>; Ma, Liang J <[email protected]>; > Mccarthy, Peter <[email protected]>; Shepard Siegel > <[email protected]>; Ed Czeck <[email protected]>; > John Miller <[email protected]>; Igor Russkikh > <[email protected]>; Pavel Belous <[email protected]>; > Rasesh Mody <[email protected]>; Shahed Shaikh > <[email protected]>; Somnath Kotur <[email protected]>; > Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; > Rahul Lakkireddy <[email protected]>; Guo, Jia > <[email protected]>; Wang, Haiyue <[email protected]>; Marcin > Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy > Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; > Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; > Wang, Xiao W <[email protected]>; Yang, Qiming > <[email protected]>; Alfredo Cardigliano <[email protected]>; > Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; > Viacheslav Ovsiienko <[email protected]>; Zyta Szpak > <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger > <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang > Zhang <[email protected]>; Long Li <[email protected]>; Heinrich > Kuhn <[email protected]>; Harman Kalra > <[email protected]>; Kiran Kumar K <[email protected]>; Andrew > Rybchenko <[email protected]>; Singh, Jasvinder > <[email protected]>; Jiawen Wu <[email protected]>; Jian > Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti > <[email protected]>; Burakov, Anatoly <[email protected]>; > Maxime Coquelin <[email protected]>; Xia, Chenbo > <[email protected]> > Cc: [email protected] > Subject: Re: [RFC] remove unused functions > > On 11/23/2020 2:55 AM, Zhang, Tianfei wrote: > >> drivers/raw/ifpga/base/opae_eth_group.c | 25 - > >> drivers/raw/ifpga/base/opae_eth_group.h | 1 - > >> drivers/raw/ifpga/base/opae_hw_api.c | 212 -- > >> drivers/raw/ifpga/base/opae_hw_api.h | 36 - > >> drivers/raw/ifpga/base/opae_i2c.c | 12 - > >> drivers/raw/ifpga/base/opae_i2c.h | 4 - > >> drivers/raw/ifpga/base/opae_ifpga_hw_api.c | 99 - > >> drivers/raw/ifpga/base/opae_ifpga_hw_api.h | 15 - > > > > The ifpga base code is want to provide fully functionality low level > > hardware > support for Intel FPGA card like N3000, even though some APIs are not used > by DPDK framework now，but it will useful for end-users or other customers > developing their own productions , my opinion is keeping those APIs of ifpga > base code in DPDK. > > > > The code is hidden behind the driver code, it is not accessible to user > directly. > > If the idea is the code can be used later, it can be added when needed.
Sound good! > > If the idea is the code can be needed in the field by users, can you please > give > example on the use case? Do you mean write some test cases in examples folder?
