> -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@intel.com> > Sent: 2020年11月23日 17:57 > To: Zhang, Tianfei <tianfei.zh...@intel.com>; Jerin Jacob > <jer...@marvell.com>; Dumitrescu, Cristian <cristian.dumitre...@intel.com>; > Hemant Agrawal <hemant.agra...@nxp.com>; Sachin Saxena > <sachin.sax...@oss.nxp.com>; Ray Kinsella <m...@ashroe.eu>; Neil Horman > <nhor...@tuxdriver.com>; Xu, Rosen <rosen...@intel.com>; Wu, Jingjing > <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; Nithin > Dabilpuram <ndabilpu...@marvell.com>; Ajit Khaparde > <ajit.khapa...@broadcom.com>; Raveendra Padasalagi > <raveendra.padasal...@broadcom.com>; Vikas Gupta > <vikas.gu...@broadcom.com>; Gagandeep Singh <g.si...@nxp.com>; > Somalapuram Amaranath <asoma...@amd.com>; Akhil Goyal > <akhil.go...@nxp.com>; Jay Zhou <jianjay.z...@huawei.com>; McDaniel, > Timothy <timothy.mcdan...@intel.com>; Ma, Liang J <liang.j...@intel.com>; > Mccarthy, Peter <peter.mccar...@intel.com>; Shepard Siegel > <shepard.sie...@atomicrules.com>; Ed Czeck <ed.cz...@atomicrules.com>; > John Miller <john.mil...@atomicrules.com>; Igor Russkikh > <igor.russk...@aquantia.com>; Pavel Belous <pavel.bel...@aquantia.com>; > Rasesh Mody <rm...@marvell.com>; Shahed Shaikh > <shsha...@marvell.com>; Somnath Kotur <somnath.ko...@broadcom.com>; > Chas Williams <ch...@att.com>; Min Hu (Connor) <humi...@huawei.com>; > Rahul Lakkireddy <rahul.lakkire...@chelsio.com>; Guo, Jia > <jia....@intel.com>; Wang, Haiyue <haiyue.w...@intel.com>; Marcin > Wojtas <m...@semihalf.com>; Michal Krawczyk <m...@semihalf.com>; Guy > Tzalik <gtza...@amazon.com>; Evgeny Schemeilin <evge...@amazon.com>; > Igor Chauskin <igo...@amazon.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; > Wang, Xiao W <xiao.w.w...@intel.com>; Yang, Qiming > <qiming.y...@intel.com>; Alfredo Cardigliano <cardigli...@ntop.org>; > Matan Azrad <ma...@nvidia.com>; Shahaf Shuler <shah...@nvidia.com>; > Viacheslav Ovsiienko <viachesl...@nvidia.com>; Zyta Szpak > <z...@semihalf.com>; Liron Himi <lir...@marvell.com>; Stephen Hemminger > <sthem...@microsoft.com>; K. Y. Srinivasan <k...@microsoft.com>; Haiyang > Zhang <haiya...@microsoft.com>; Long Li <lon...@microsoft.com>; Heinrich > Kuhn <heinrich.k...@netronome.com>; Harman Kalra > <hka...@marvell.com>; Kiran Kumar K <kirankum...@marvell.com>; Andrew > Rybchenko <andrew.rybche...@oktetlabs.ru>; Singh, Jasvinder > <jasvinder.si...@intel.com>; Jiawen Wu <jiawe...@trustnetic.com>; Jian > Wang <jianw...@trustnetic.com>; Ori Kam <or...@nvidia.com>; Guy Kaneti > <g...@marvell.com>; Burakov, Anatoly <anatoly.bura...@intel.com>; > Maxime Coquelin <maxime.coque...@redhat.com>; Xia, Chenbo > <chenbo....@intel.com> > Cc: dev@dpdk.org > Subject: Re: [RFC] remove unused functions > > On 11/23/2020 2:55 AM, Zhang, Tianfei wrote: > >> drivers/raw/ifpga/base/opae_eth_group.c | 25 - > >> drivers/raw/ifpga/base/opae_eth_group.h | 1 - > >> drivers/raw/ifpga/base/opae_hw_api.c | 212 -- > >> drivers/raw/ifpga/base/opae_hw_api.h | 36 - > >> drivers/raw/ifpga/base/opae_i2c.c | 12 - > >> drivers/raw/ifpga/base/opae_i2c.h | 4 - > >> drivers/raw/ifpga/base/opae_ifpga_hw_api.c | 99 - > >> drivers/raw/ifpga/base/opae_ifpga_hw_api.h | 15 - > > > > The ifpga base code is want to provide fully functionality low level > > hardware > support for Intel FPGA card like N3000, even though some APIs are not used > by DPDK framework now，but it will useful for end-users or other customers > developing their own productions , my opinion is keeping those APIs of ifpga > base code in DPDK. > > > > The code is hidden behind the driver code, it is not accessible to user > directly. > > If the idea is the code can be used later, it can be added when needed.
Sound good! > > If the idea is the code can be needed in the field by users, can you please > give > example on the use case? Do you mean write some test cases in examples folder?
