Hi,
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yi...@intel.com>
> Sent: Thursday, November 19, 2020 11:53
> To: Jerin Jacob <jer...@marvell.com>; Dumitrescu, Cristian
> <cristian.dumitre...@intel.com>; Hemant Agrawal
> <hemant.agra...@nxp.com>; Sachin Saxena <sachin.sax...@oss.nxp.com>;
> Ray Kinsella <m...@ashroe.eu>; Neil Horman <nhor...@tuxdriver.com>; Xu,
> Rosen <rosen...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing,
> Beilei <beilei.x...@intel.com>; Nithin Dabilpuram
> <ndabilpu...@marvell.com>; Ajit Khaparde
> <ajit.khapa...@broadcom.com>; Raveendra Padasalagi
> <raveendra.padasal...@broadcom.com>; Vikas Gupta
> <vikas.gu...@broadcom.com>; Gagandeep Singh <g.si...@nxp.com>;
> Somalapuram Amaranath <asoma...@amd.com>; Akhil Goyal
> <akhil.go...@nxp.com>; Jay Zhou <jianjay.z...@huawei.com>; McDaniel,
> Timothy <timothy.mcdan...@intel.com>; Ma, Liang J <liang.j...@intel.com>;
> Mccarthy, Peter <peter.mccar...@intel.com>; Shepard Siegel
> <shepard.sie...@atomicrules.com>; Ed Czeck <ed.cz...@atomicrules.com>;
> John Miller <john.mil...@atomicrules.com>; Igor Russkikh
> <igor.russk...@aquantia.com>; Pavel Belous <pavel.bel...@aquantia.com>;
> Rasesh Mody <rm...@marvell.com>; Shahed Shaikh
> <shsha...@marvell.com>; Somnath Kotur
> <somnath.ko...@broadcom.com>; Chas Williams <ch...@att.com>; Min Hu
> (Connor) <humi...@huawei.com>; Rahul Lakkireddy
> <rahul.lakkire...@chelsio.com>; Guo, Jia <jia....@intel.com>; Wang,
> Haiyue <haiyue.w...@intel.com>; Marcin Wojtas <m...@semihalf.com>;
> Michal Krawczyk <m...@semihalf.com>; Guy Tzalik <gtza...@amazon.com>;
> Evgeny Schemeilin <evge...@amazon.com>; Igor Chauskin
> <igo...@amazon.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; Wang, Xiao W
> <xiao.w.w...@intel.com>; Yang, Qiming <qiming.y...@intel.com>; Alfredo
> Cardigliano <cardigli...@ntop.org>; Matan Azrad <ma...@nvidia.com>;
> Shahaf Shuler <shah...@nvidia.com>; Viacheslav Ovsiienko
> <viachesl...@nvidia.com>; Zyta Szpak <z...@semihalf.com>; Liron Himi
> <lir...@marvell.com>; Stephen Hemminger <sthem...@microsoft.com>; K.
> Y. Srinivasan <k...@microsoft.com>; Haiyang Zhang
> <haiya...@microsoft.com>; Long Li <lon...@microsoft.com>; Heinrich Kuhn
> <heinrich.k...@netronome.com>; Harman Kalra <hka...@marvell.com>;
> Kiran Kumar K <kirankum...@marvell.com>; Andrew Rybchenko
> <andrew.rybche...@oktetlabs.ru>; Singh, Jasvinder
> <jasvinder.si...@intel.com>; Jiawen Wu <jiawe...@trustnetic.com>; Jian
> Wang <jianw...@trustnetic.com>; Zhang, Tianfei
> <tianfei.zh...@intel.com>; Ori Kam <or...@nvidia.com>; Guy Kaneti
> <g...@marvell.com>; Burakov, Anatoly <anatoly.bura...@intel.com>;
> Maxime Coquelin <maxime.coque...@redhat.com>; Xia, Chenbo
> <chenbo....@intel.com>
> Cc: Yigit, Ferruh <ferruh.yi...@intel.com>; dev@dpdk.org
> Subject: [RFC] remove unused functions
>
> Removing unused functions, reported by cppcheck.
>
> Easy way to remove clutter, since the code is already in the git repo,
> they can be added back when needed.
>
> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com>
> ---
> drivers/bus/ifpga/ifpga_common.c | 23 -
> drivers/bus/ifpga/ifpga_common.h | 3 -
>
> diff --git a/drivers/bus/ifpga/ifpga_common.c
> b/drivers/bus/ifpga/ifpga_common.c
> index 78e2eaee4e..7281b169d0 100644
> --- a/drivers/bus/ifpga/ifpga_common.c
> +++ b/drivers/bus/ifpga/ifpga_common.c
> @@ -52,29 +52,6 @@ int rte_ifpga_get_integer32_arg(const char *key
> __rte_unused,
>
> return 0;
> }
> -int ifpga_get_integer64_arg(const char *key __rte_unused,
> - const char *value, void *extra_args)
> -{
> - if (!value || !extra_args)
> - return -EINVAL;
> -
> - *(uint64_t *)extra_args = strtoull(value, NULL, 0);
> -
> - return 0;
> -}
> -int ifpga_get_unsigned_long(const char *str, int base)
> -{
> - unsigned long num;
> - char *end = NULL;
> -
> - errno = 0;
> -
> - num = strtoul(str, &end, base);
> - if ((str[0] == '\0') || (end == NULL) || (*end != '\0') || (errno != 0))
> - return -1;
> -
> - return num;
> -}
>
> int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0,
> const struct rte_afu_id *afu_id1)
> diff --git a/drivers/bus/ifpga/ifpga_common.h
> b/drivers/bus/ifpga/ifpga_common.h
> index f9254b9d5d..44381eb78d 100644
> --- a/drivers/bus/ifpga/ifpga_common.h
> +++ b/drivers/bus/ifpga/ifpga_common.h
> @@ -9,9 +9,6 @@ int rte_ifpga_get_string_arg(const char *key
> __rte_unused,
> const char *value, void *extra_args);
> int rte_ifpga_get_integer32_arg(const char *key __rte_unused,
> const char *value, void *extra_args);
> -int ifpga_get_integer64_arg(const char *key __rte_unused,
> - const char *value, void *extra_args);
> -int ifpga_get_unsigned_long(const char *str, int base);
> int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0,
> const struct rte_afu_id *afu_id1);
>
> 2.26.2
Reviewed-by: Rosen Xu <rosen...@intel.com>
