Hi,
> -----Original Message-----
> From: Yigit, Ferruh <[email protected]>
> Sent: Thursday, November 19, 2020 11:53
> To: Jerin Jacob <[email protected]>; Dumitrescu, Cristian
> <[email protected]>; Hemant Agrawal
> <[email protected]>; Sachin Saxena <[email protected]>;
> Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu,
> Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing,
> Beilei <[email protected]>; Nithin Dabilpuram
> <[email protected]>; Ajit Khaparde
> <[email protected]>; Raveendra Padasalagi
> <[email protected]>; Vikas Gupta
> <[email protected]>; Gagandeep Singh <[email protected]>;
> Somalapuram Amaranath <[email protected]>; Akhil Goyal
> <[email protected]>; Jay Zhou <[email protected]>; McDaniel,
> Timothy <[email protected]>; Ma, Liang J <[email protected]>;
> Mccarthy, Peter <[email protected]>; Shepard Siegel
> <[email protected]>; Ed Czeck <[email protected]>;
> John Miller <[email protected]>; Igor Russkikh
> <[email protected]>; Pavel Belous <[email protected]>;
> Rasesh Mody <[email protected]>; Shahed Shaikh
> <[email protected]>; Somnath Kotur
> <[email protected]>; Chas Williams <[email protected]>; Min Hu
> (Connor) <[email protected]>; Rahul Lakkireddy
> <[email protected]>; Guo, Jia <[email protected]>; Wang,
> Haiyue <[email protected]>; Marcin Wojtas <[email protected]>;
> Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>;
> Evgeny Schemeilin <[email protected]>; Igor Chauskin
> <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao W
> <[email protected]>; Yang, Qiming <[email protected]>; Alfredo
> Cardigliano <[email protected]>; Matan Azrad <[email protected]>;
> Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko
> <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi
> <[email protected]>; Stephen Hemminger <[email protected]>; K.
> Y. Srinivasan <[email protected]>; Haiyang Zhang
> <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn
> <[email protected]>; Harman Kalra <[email protected]>;
> Kiran Kumar K <[email protected]>; Andrew Rybchenko
> <[email protected]>; Singh, Jasvinder
> <[email protected]>; Jiawen Wu <[email protected]>; Jian
> Wang <[email protected]>; Zhang, Tianfei
> <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti
> <[email protected]>; Burakov, Anatoly <[email protected]>;
> Maxime Coquelin <[email protected]>; Xia, Chenbo
> <[email protected]>
> Cc: Yigit, Ferruh <[email protected]>; [email protected]
> Subject: [RFC] remove unused functions
>
> Removing unused functions, reported by cppcheck.
>
> Easy way to remove clutter, since the code is already in the git repo,
> they can be added back when needed.
>
> Signed-off-by: Ferruh Yigit <[email protected]>
> ---
> drivers/bus/ifpga/ifpga_common.c | 23 -
> drivers/bus/ifpga/ifpga_common.h | 3 -
>
> diff --git a/drivers/bus/ifpga/ifpga_common.c
> b/drivers/bus/ifpga/ifpga_common.c
> index 78e2eaee4e..7281b169d0 100644
> --- a/drivers/bus/ifpga/ifpga_common.c
> +++ b/drivers/bus/ifpga/ifpga_common.c
> @@ -52,29 +52,6 @@ int rte_ifpga_get_integer32_arg(const char *key
> __rte_unused,
>
> return 0;
> }
> -int ifpga_get_integer64_arg(const char *key __rte_unused,
> - const char *value, void *extra_args)
> -{
> - if (!value || !extra_args)
> - return -EINVAL;
> -
> - *(uint64_t *)extra_args = strtoull(value, NULL, 0);
> -
> - return 0;
> -}
> -int ifpga_get_unsigned_long(const char *str, int base)
> -{
> - unsigned long num;
> - char *end = NULL;
> -
> - errno = 0;
> -
> - num = strtoul(str, &end, base);
> - if ((str[0] == '\0') || (end == NULL) || (*end != '\0') || (errno != 0))
> - return -1;
> -
> - return num;
> -}
>
> int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0,
> const struct rte_afu_id *afu_id1)
> diff --git a/drivers/bus/ifpga/ifpga_common.h
> b/drivers/bus/ifpga/ifpga_common.h
> index f9254b9d5d..44381eb78d 100644
> --- a/drivers/bus/ifpga/ifpga_common.h
> +++ b/drivers/bus/ifpga/ifpga_common.h
> @@ -9,9 +9,6 @@ int rte_ifpga_get_string_arg(const char *key
> __rte_unused,
> const char *value, void *extra_args);
> int rte_ifpga_get_integer32_arg(const char *key __rte_unused,
> const char *value, void *extra_args);
> -int ifpga_get_integer64_arg(const char *key __rte_unused,
> - const char *value, void *extra_args);
> -int ifpga_get_unsigned_long(const char *str, int base);
> int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0,
> const struct rte_afu_id *afu_id1);
>
> 2.26.2
Reviewed-by: Rosen Xu <[email protected]>
