[dpdk-dev] [PATCH 2/3 v3] net/dpaa: support RX offload for error packet drop

[nipun . gupta]

From: Nipun Gupta <nipun.gu...@nxp.com>

This patch supports RX offload configuration to drop error
packets in the hardware

Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com>
---
 drivers/bus/dpaa/base/fman/fman_hw.c |  7 ++++++-
 drivers/net/dpaa/dpaa_ethdev.c       | 23 +++++++++++++++++++----
 2 files changed, 25 insertions(+), 5 deletions(-)

diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c 
b/drivers/bus/dpaa/base/fman/fman_hw.c
index 4ab49f785..40e4e0000 100644
--- a/drivers/bus/dpaa/base/fman/fman_hw.c
+++ b/drivers/bus/dpaa/base/fman/fman_hw.c
@@ -597,7 +597,12 @@ void
 fman_if_discard_rx_errors(struct fman_if *fm_if)
 {
        struct __fman_if *__if = container_of(fm_if, struct __fman_if, __if);
-       unsigned int *fmbm_rfsdm, *fmbm_rfsem;
+       unsigned int *fmbm_rcfg, *fmbm_rfsdm, *fmbm_rfsem;
+       unsigned int val;
+
+       fmbm_rcfg = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rcfg;
+       val = in_be32(fmbm_rcfg);
+       out_be32(fmbm_rcfg, val & ~BMI_PORT_CFG_FDOVR);
 
        fmbm_rfsem = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rfsem;
        out_be32(fmbm_rfsem, 0);
diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index af47c196a..bed84a584 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -52,7 +52,8 @@
 /* Supported Rx offloads */
 static uint64_t dev_rx_offloads_sup =
                DEV_RX_OFFLOAD_JUMBO_FRAME |
-               DEV_RX_OFFLOAD_SCATTER;
+               DEV_RX_OFFLOAD_SCATTER |
+               DEV_RX_OFFLOAD_ERR_PKT_DROP;
 
 /* Rx offloads which cannot be disabled */
 static uint64_t dev_rx_offloads_nodis =
@@ -62,6 +63,10 @@ static uint64_t dev_rx_offloads_nodis =
                DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
                DEV_RX_OFFLOAD_RSS_HASH;
 
+/* Supported Rx Error packet drop offload */
+static uint64_t dev_rx_err_drop_offloads_sup =
+               DEV_RX_ERR_PKT_DROP_OFFLOAD_ALL;
+
 /* Supported Tx offloads */
 static uint64_t dev_tx_offloads_sup =
                DEV_TX_OFFLOAD_MT_LOCKFREE |
@@ -262,6 +267,18 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)
                dev->data->scattered_rx = 1;
        }
 
+       if (eth_conf->err_pkt_drop_conf.all) {
+               DPAA_PMD_DEBUG("error packets will be dropped on hw");
+               fman_if_discard_rx_errors(fif);
+       } else {
+               struct dpaa_if *dpaa_intf = dev->data->dev_private;
+               struct qman_fq *rxq = &dpaa_intf->rx_queues[0];
+
+               DPAA_PMD_DEBUG("error packets will not be dropped on hw");
+               fman_if_receive_rx_errors(fif, FM_FD_RX_STATUS_ERR_MASK);
+               fman_if_set_err_fqid(fif, rxq->fqid);
+       }
+
        if (!(default_q || fmc_q)) {
                if (dpaa_fm_config(dev,
                        eth_conf->rx_adv_conf.rss_conf.rss_hf)) {
@@ -591,6 +608,7 @@ static int dpaa_eth_dev_info(struct rte_eth_dev *dev,
                                        dev_rx_offloads_nodis;
        dev_info->tx_offload_capa = dev_tx_offloads_sup |
                                        dev_tx_offloads_nodis;
+       dev_info->rx_err_drop_offload_capa = dev_rx_err_drop_offloads_sup;
        dev_info->default_rxportconf.burst_size = DPAA_DEF_RX_BURST_SIZE;
        dev_info->default_txportconf.burst_size = DPAA_DEF_TX_BURST_SIZE;
        dev_info->default_rxportconf.nb_queues = 1;
@@ -2085,9 +2103,6 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)
                fman_intf->mac_addr.addr_bytes[5]);
 
        if (!fman_intf->is_shared_mac) {
-               /* Configure error packet handling */
-               fman_if_receive_rx_errors(fman_intf,
-                       FM_FD_RX_STATUS_ERR_MASK);
                /* Disable RX mode */
                fman_if_disable_rx(fman_intf);
                /* Disable promiscuous mode */
-- 
2.17.1