> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per > queue > > On Fri, Oct 9, 2020 at 10:36 AM Pattan, Reshma <reshma.pat...@intel.com> > wrote: > > > >> +* ethdev: Renamed basic statistics per queue. An underscore is > > > >> +inserted > > > >> + between the queue number and the rest of the xstat name: > > > >> + > > > >> + * ``rx_qN*`` -> ``rx_qN_*`` > > > >> + * ``tx_qN*`` -> ``tx_qN_*`` > > > >> + > > > > > > > >As far as I remember collect plugin was using xstat output, does > > > >this rename affects it? Or any other telemetry application relying on > > > >xstats. > > > > > > > >Harry, Ciara, Kevin, do you know anything that will be affected from > rename? > > > > > > I don't think this change will affect anything with telemetry > > > itself, but I am not so familiar with the CollectD plugin, Reshma may be > > > able > to verify that. > > > > Neither collectd has any dependency on naming. > > I am not sure about this statement. > collectd dpdkstats plugin does seem to inspect the names. >
Hi, I should have been more clear on this, It is dpdk_telemetry plugin of collectd I am talking about, as I worked on that. dpdk_telemetry plugin of collectd do not have dependency on the naming. dpdkstats plugin I did not work on, so I cannot comment on that, might be Harry able to help with that . Thanks, Reshma
