10/07/2020 20:31, Dmitry Kozlyuk: > On Fri, 10 Jul 2020 13:53:24 +0200, Thomas Monjalon wrote: > > --- /dev/null > > +++ b/lib/librte_eal/windows/include/sys/mman.h > > @@ -0,0 +1,9 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright 2020 Mellanox Technologies, Ltd > > + */ > > + > > +/* > > + * The syscall mmap does not exist on Windows, > > + * but this error code is used in a badly defined DPDK API for PCI mapping. > > + */ > > +#define MAP_FAILED ((void *) -1) > > I see why we can't help exposing <sys/mman.h> in <rte_eal_paging.h>, but I'm > against adding this stub header. Why not make #include <sys/mman.h> > conditional and define MAP_FAIELD in <rte_os.h> for Windows?
Yes this macro can be in lib/librte_eal/windows/include/rte_os.h I'll do a v2.
